Chris Hennes

Results 697 comments of Chris Hennes

Really for me the easy fix is to remove the checks for Markdown: it is basically obsolete in the current Addon Manager, it's not used by the mainline code anymore....

There is another ongoing forums discussion with a related, though more comprehensive, fix: https://forum.freecadweb.org/viewtopic.php?f=10&t=70790

Does this still crash with 7.6.1?

So we can mitigate the crash by checking TF before accessing it: it won't make the fillet work, but it will resolve the hard crash. Do you want to register...

I can tell you that the OCCT team pays no attention to code submitted as part of a ticket because they usually don't have a Contributor License Agreement from the...

Patch submitted upstream: https://git.dev.opencascade.org/gitweb/?p=occt.git;a=commit;h=b0a5939a3dcddae4ed4edba4d1b56071282fcf4c Maybe the team at OCC an help create a Draw case to exercise this.

(@adrianinsaval you can find the documentation for the Draw test harness here: https://dev.opencascade.org/doc/overview/html/occt_user_guides__test_harness.html -- you will probably need an OCCT account to access it)

They requested code that demonstrates the failure.

I'm totally amenable to it: we should probably have a generic set of checks that run, and that can be one of them. Obviously it's not going to happen until...

It's all-caps SIGNAL and all-caps SLOT that we want to look for and reject -- the initial part of the line is often the same between the two styles.