chemag
chemag
I like large comments (it's a doc, after all), but please feel free to remove what you decide
> Documentation for the user would belong in a man page; documentation for libpcap developers would belong in a comment in the code. I removed all the test notes.
> Is there any reason to run raw filters through the optimizer? Presumably if a user specifies a raw filter, they want exactly that chunk of BPF machine code to...
> Actually, the kernel defines it as 512, as do the kernel and the kernel and the kernel and the kernel ... My bad. There's only [one kernel](https://www.kernel.org/) for me...
One more ping...
> if there is still interest, please rebase, thank you! Done. Tested again, and added a "Tested:" section to the patch comment. Thanks!
Also, per a previous comment from Guy, I moved a chunk of the comment to the `pcap_compile` man page
I also have a patch to force the mode (silk, hybrid, celt, auto), but the `OPUS_SET_FORCE_MODE` API is private. I can just copy the values, but I assume there's a...