Chris Heald

Results 42 comments of Chris Heald

I'm backed up on another task at the moment, but I'll try to get to it soon!

This is still an issue 4+ months later, apparently.

The 1.8.7 failures appear to be present in master, as well, running them locally with `BUNDLE_GEMFILE=$PWD/.travis/Gemfile rake`. Running just `rake` passes the suite as expected. I'm reasonably confident that these...

It looks like the issue is the difference between test_unit 3.1.5 and 3.1.7. Locking test_unit to 3.1.5 causes the suite to pass.

Certainly! You'll find it at #593

Looks like a simple merge. I've rebased it to master. I don't currently have a production use case for this, but let me know if it works for you.

I'll see what I can do to make Rubocop happy.

I had this problem show up suddenly after upgrading from webpacker 3 to 4. Changing `swap` to `insert_before` seems to work just fine, though: ``` Rails.application.middleware.insert_before( Rails::Rack::Logger, Silencer::Logger, ...) ```

Svg tags and transformers are not sufficient, because the Svg implementation doesn't support everything that pdfkit is capable of handling, such as text on paths. A feature like https://github.com/diegomura/react-pdf/issues/973 would...

Heh, wow, not often I see a 3 year old PR get necroed. Sure, I went ahead and rebased my branch onto master. It did rebase cleanly, but I didn't...