Dinesh Ch

Results 31 comments of Dinesh Ch

@quangngotan95 Can you look into merging this?

@maiiku This PR reverts your change in #465 to have `None` for firstName and lastName in apple backend when it does not get name details. This could break things in...

@maiiku Since most other backends in `social-core` give empty strings for such cases, the projects supporting multiple authentication methods dependent on `social-core` will have code to handle empty strings and...

> I don't understand why CodeQL is complaining about logging a username 🤔 ~~Apparently it's some issue on GitHub's side. It's failing for all other PRs(on master) too.~~ nvm, I...

@timabbott I'll check why the tests are failing and try to make it work. @andersk I use `user-agents` module as @timabbott suggested in the issue discussion page. shall I change...

the tests failed for the user-agent ZulipAndroid as discussed here https://chat.zulip.org/#narrow/stream/9-issues/topic/Issue.20.2313098.20-.20user.20agents/near/790013 changing the code to ``` if 'android' in user_agent.lower(): return 'Android' else: user_agent_info = parse(user_agent) return user_agent_info.os.family ``` works.would...

some in `zerver/tests/test_new_users.py` were failing - as user-agents module cannot detect user_agent "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:47.0) Gecko/20100101 Firefox/47.0" because of changing it to lowercase with `user_agent =...

I have corrected the user agent strings in `zerver/tests/test_new_users.py` and just used the `ua_parser` module. @andersk Thanks for the earlier review. Please check if everything is alright now.

@timabbott please consider reviewing and merging this PR as merging a commit that changes `PROVISION_VERSION` in `version.py` to master is resulting in conflict to this PR.

@timabbott I've added comments for the changes in tests.