chdastolfo

Results 5 comments of chdastolfo

Adding type hints as @rhymiz requested is non-blocking, but would prefer them to be added before merge @albcl. Would prefer to merge both of your PRs at the same time,...

@iramluism I'd second @rhymiz request, and also ask that you add tests to check that logic and that the query is formed correctly when passed different input types. Thank you!

Hi everyone - this has been released. Thanks for your input and patience!

Also! Please add this method to the docs in `docs/README.rst`

This is fine, though makes more sense to just include this in your other PRs (as you've done) and then close this one once those are merged.