Carl Hauser

Results 25 comments of Carl Hauser

Command activation and deactivation buttons do not work properly.

This should have been fixed by the fix for allwpilib#5323 but it should be checked. Will need to use allwpilib HEAD for the test. I am not able to do...

Documentation for `PIDController.setIntegratorRange` is incorrect; some checks for non-negativity of the PID constants are missing

The suggested rewording above is still wrong. ``` /** * Sets the minimum and maximum values for the integrator. * * If the integrator value is outside the range [minimumIntegral/ki..maximumIntegral/ki]...

Documentation for `PIDController.setIntegratorRange` is incorrect; some checks for non-negativity of the PID constants are missing

Finally, there is no check that ensures `minimumIntegral

`SmartDashboard.setDefault*` documentation

/format

Driver Station Timing Window always says good timing

And the x-axis has no time scale making it hard to cross-reference information displayed here to anything else.

`SmartDashboard.setDefault*` documentation

Still WIP

`SmartDashboard.setDefault*` documentation

I think this is ready for re-review. While I was fixing SmartDashboard.h I noticed that the Get* methods also were erroneous in saying that their defaultValue would be "set" if...

TrapezoidProfile methods (somewhat) incompatible with new API

In the java code m_current is not initialized so will be null and uninitialized (in code) scalars will be initialized to zero. (edit) Oh I see you were saying the...

Unhandled exception from `runOnce` command called from a Trigger if it creates further Triggers.

Yes -- the idea is to only bind those commands when the test controller is plugged in so that we can have the test code always present in the robot...

Unhandled exception from `runOnce` command called from a Trigger if it creates further Triggers.

No pressure from me to change it.