Chase Finch

AMP Optimizer shouldn’t strip `sizes` without `srcset`

1

In `packages/optimizer/lib/transformers/ApplyCommonAttributes.js` line 81-83, the optimizer strips the `sizes` attribute when `srcset` is not also present. Here is the related comment in the code:: > // According to the Mozilla...

string_processing: Use explicit string concatenation

13

**Describe the style change** I suggest to use explicit string concatenation, instead of implicit concatenation, for (currently experimental) string processing, with whitespace pushed to the end of each line. **Examples...

There are two related problems with the current implementation: - [ ] A `sizes` attribute on an `amp-img` with `data-hero` specified is applied to the injected `img` tag*, but then...

Enable & pass additional 2 spec tests

1

Currently, media queries are not grouped by their media condition, and this causes two tests to fail: - [x] ~`converts_heights_attribute_to_css`~ - [ ] `converts_media_attribute_to_css` When implementing media grouping, re-add these...

Seems like all of the CDN endpoints are down. https://cdn.ampproject.org/bento.js https://cdn.ampproject.org/bento.mjs And, all of the component URLs are all returning 404s.

Technically still experimental, but it has support in major browsers and the API seems likely to remain stable. https://developer.mozilla.org/en-US/docs/Web/API/AbortController https://developers.google.com/web/updates/2017/09/abortable-fetch