Raghavendra Chary B
Raghavendra Chary B
+1 This can be accomplished by introducing TaskStatusListener interface so that when a task is scheduled it can notify implementor of TaskStatusListener interface. Implementor can be a web-hook call. More...
In the past, there was an attempt to implement Redlock in Dynomite itself. Please refer https://github.com/Netflix/conductor/issues/759 https://github.com/Netflix/conductor/issues/1137 There was a ask for this same feature request in below comment https://github.com/Netflix/conductor/issues/1137#issuecomment-537250349
Will soon create a PR
still working the code changes
Hi @youngledo , your changes were in branch charybr:feature/webhook. I cherry-picked your commits into branch of this PR i.e. charybr:feature/task_webhook. So please review below commits: https://github.com/Netflix/conductor-community/pull/228/commits/20a609da9ab6b343000567599331f1ebeba5465a https://github.com/Netflix/conductor-community/pull/228/commits/42c7ae255c94126fc67ea35d0153eb34ff275b7d
Commenting so that Stale label gets removed. Will work on the review comments in Dec.
I think we need to instantiate DynoLockClient in Conductor. Is it right?
Hi @rsrinivasanNetflix , https://github.com/Netflix/dyno/blob/0552980e8cd3cb81fd4fb83787e44107f13e422e/dyno-recipes/src/main/java/com/netflix/dyno/recipes/lock/VotingHostsFromTokenRange.java#L36 In VotingHostsFromToken when votingSize is not provided (i.e DEFAULT_LOCK_VOTING_SIZE = -1 in ConnectionPoolConfigurationImpl) effectiveVotingSize is set to MAX_VOTING_SIZE (5). This makes it DynoLockClient quorum to 3....
thank you @CollinDewey for continuing this.