Charles OConor comments

Results 12 comments of


                                            Charles OConor

Create dangling ingress check

I think it's a great idea to check the ports as well. Update the PR for that.

Create dangling ingress check

Thanks for the approval! Excited to be able to use this check I've been running into issues around this a lot lately.

Test servers never close

Are you connecting to anything? I had to close the mysql connection as well as redis to make this finish even with closing the server manually.

using gofmt and go vet in sh_test rules

If `gofmt` was exposed from the rules here it could be integrated into a tool like https://github.com/thundergolfer/bazel-linting-system which currently relies on go to be installed on the system which isn't...

Why does model_management_pb2 imports tensorflow

Couldn't you pull the proto buff definitions out of TensorFlow to a point where they could both be imported?

How to add custom metrics ?

I would look at the `promethious_client` it's what this lib is using under the hood. Those will get picked up in the endpoint. https://github.com/prometheus/client_python

Leave annotations on their own line for properties.

@cushon or someone on the team I can take a crack at this but would like a rough code pointer or know if it's impossible.

Imports of headers not handled inside inline assembly files (.s or .h)

I'm having the same issue on the latest version `v0.30.0`. My workaround, for now, is to patch in the changes to the `BUILD.bazel` files. Don't know if I have the...

[FEATURE_REQUEST] Publish a mac arm binary

I got side tracked since I've gotten all of the devs at my company to run rosetta for other reasons. The PR was closed since it wasn't ready meant to...