John Charman

Results 17 comments of John Charman

@Aribros What happens if there are duplicate operationIds in two separate paths? [Unique string used to identify the operation. The id MUST be unique among all operations described in the...

@handrews @karenetheridge If the tables need updating, I can provide some PRs for each. Just let me know whether it would be better to: - add parameter names where missing...

> We could also reconcile this in the specification by explicitly saying that if a parameter of type `object` is present, there shall be no other parameters allowed using the...

@MikeRalphson It seems I can't find an RFC for that format, it's simply how PHP formats and parses query strings. i.e. [http_build_query()](https://www.php.net/manual/en/function.http-build-query.php).

> I personally don't like to repeat in a prefix the namespace. So I'd rather see `#[Dagger\Object]` than `#[DaggerObject]` because that's really `Dagger\DaggerObject`. Not a blocker, just an opinion. 🙂...

> `#[ObjectType]` is an option. If `Function` is reserved in PHP, it could be `#[Func]` like in TS. @carnage and I just reviewed the naming conventions: We changed `#[DaggerArgument]` to...

@vikram-dagger I've added a warning that people shouldn't be using the PHP package manager for Dagger modules. It's not our intended use-case and may lead to unexpected behaviour. On that...

@vikram-dagger I've updated the wording to what, I think, sounds more clear. I think, for now, the note could stay in just the PHP tab. It's still an improvement to...

@helderco What should `format` achieve? Should it: A - Return a list of diffs showing what would have happened if it was formatted? B - Actually format the directory?

> Format should actually format, and return a diff of the changed directory. This way the returned directory can be exported to the host, overwriting only those changed files. How...