Godfrey Chan

Results 233 comments of Godfrey Chan

Yep, currently clicking on the first blame would bring you to a 404 page. Kinda sucks but not sure if it can be easily fixed. How this works is by...

I think you might have misunderstood the problem :) `123abcd^` basically means "the commit immediately before `123abcd`", so "http://gh.com/user/repo/blame/123abcd^/some/file.js" means "blame `some/file.js`, starting from the commit immediately before `123abcd`", which...

I don't have access to the enterprise UI/markup. Is it pretty close to the public one? Guthub "recently" changed the markup and broke the extension. I'll fix it over the...

Ah. I see! I wouldn't mind supporting that if someone can send a pull request ;) — Sent from Mailbox On Thu, Apr 16, 2015 at 2:26 PM, Jason Karns...

I fixed the extension! So we have one less blocker for this. It's tricky though, because we are only injecting the script based on the URLs [hardcoded in manifest.json](https://github.com/chancancode/blame_parent/blob/master/manifest.json#L7). I...

@wycats has thoughts on the strict vs loose difference (he don't think it is correct that we should have to handle them differently). He'll comment later. As for `neq` vs...

> And adding an error for > 2 arguments seems like a safe approach. I'd be happy to add that to this PR unless somebody has a strong feeling. Sounds...

It seems like this PR implemented the part where `(element ...)` returns a component, but haven't actually implemented the "when we render that component it does the right thing" part....

Maybe. Someone would need to check the updating opcode produced by something like `` where `@foo=“foo string literal”`. Ideally there should be nothing to update in this case, but according...

IE 11 tests are failing because the `precompile` output uses arrow functions which is not supported. Should I switch it to use `function() { ... }`?