Chad Greenburg
Chad Greenburg
What's the status of this PR? It appears the original issue is still a problem. Hoping this can get some traction.
We migrated a pyspark/pandas application to a workflow activity and it takes longer than 2 minutes. That's where we've seen the deadline exceeded exception. I've been replicating it using `time.sleep(150)`.
Thanks for the suggestions @firdaus! In your thread example, it's okay that the two workers use the same task queue? They don't need to be different task queues?
Here's what I've tracked down: - Temporal added [keep alive options in 1.9.0](https://github.com/temporalio/temporal/pull/1334). - The new config option `frontend.keepAliveMaxConnectionAge` [defaults to 5 minutes](https://github.com/temporalio/temporal/blob/e7cc7f2000e68b5b7d16b15ad23f33d9b6c1cd8b/service/frontend/service.go#L182) (it wasn't set prior to it being...
@vitarb this project uses grpclib, which uses [h2](https://github.com/python-hyper/h2). You're spot on that it isn't handling the `GoAway` signal properly ([issue](https://github.com/python-hyper/h2/issues/1181))
I agree with you. A couple of options are: - Implement GoAway handling in the h2 library - Update to use grpcio channel over grpclib channel - maybe grpcio's channel...
As we've continued migrating existing applications to temporal using the python-sdk, it looks like we also need to override the config option `frontend.keepAliveTime`. Temporal server [sets it to 1 minute](https://github.com/temporalio/temporal/blob/e7cc7f2000e68b5b7d16b15ad23f33d9b6c1cd8b/service/frontend/service.go#L184)....
I'm also running into this issue. I set cookies in my API but the cookies won't persist in the browser since the `Access-Control-Allow-Credentials` header doesn't return true from the OPTIONS...
@dz902 I hadn't noticed it was reverted. I reached out on the revert pull request (#1664) to see why.
Whoops, I had made the original commit directly from Github without cloning and testing. I've updated the tests and everything is working. This is a breaking change to existing functionality...