Christoph Schulze
Christoph Schulze
@weiznich Sorry it took me so long coming back to you. I believe it is good practice to use credential rotation for databases [1]. Therefore, I would expect diesel to...
Thanks @berkaysynnada! Yeah I'd like to get a review. There is still a bug, though, that I don't understand yet. Sometimes the sort operator gets removed as can be seen...
@berkaysynnada do you have time to take another look? :) `NotEq` leads to the removal of the sort operator. I debugged into this and noticed that the `EnforceSorting` optimiser removes...
> I try to add support for NotEq. If I find a solution, I can fix it within this PR itself—if that's okay with you. Sure, feel free to make...
> I took a quick look, and you can use the union logic there I thought a bit more about the union logic and came up with another solution. Sometimes...
Looks like I confused the meaning of nulls in intervals. I switched to the union logic @berkaysynnada suggested.
@berkaysynnada thank you for your review 🙂 > Rather than introducing new supports_() API's, should we force the users to infer the support by the evaluate API? I agree, something...
Hi @berkaysynnada, I should be able to spend some time on this at the end of this week.
Hi @berkaysynnada, can you take another look to move this forward? :)
Sorry @berkaysynnada, I got side-tracked from this yesterday. The test is fixed.