Carmi Grushko

Generated BUILD files should use `java_import` instead of `java_library`

11

That is, instead of ``` java_library( name = "args4j", exports = [ "//external:jar/args4j/args4j" ], runtime_deps =[ ], visibility = [ "//visibility:public" ] ) ``` we should have ``` java_import( name...

Take Maven coords instead of YAML

6

... well, maybe not instead, both support something like ``` dependencies: 'javax.servlet:javax.servlet-api:jar:4.0.0' ``` Instead of ``` dependencies: javax.servlet: javax.servlet-api: version: "4.0.0" lang: java ```

Consider renaming the project to 'bazel-maven-deps'

3

I think 'bazel-manve-deps' (or something with "maven" in it) will help users discover this tool. Sorry if I'm a bit intrusive :) CC @googlestanke

Projects have different compiler-flags and/or defines based on whether this is a release or debug build. We should update the ios-app/ example to show how to do so.

Conditional OpenOp / CloseOp

2

In `ktfmt`, I'd like to format the following: ``` fun longName() = coroutineScope { foo() // } ``` but if it doesn't fit in a single line, I'd like to...

A space is inserted after slash-star /* comments

1

GJF emits the following: ``` f(43 /*bla */ ) ``` (when the max line width is short enough) Note the space between the closing `*/` and the closing `)`. This...

(Prepare for) Handling trailing spaces in multiline strings

9

We ran into this issue with [ktfmt](https://github.com/facebookincubator/ktfmt), and solved it by replacing the last of the trailing spaces with a special tombstone to prevent GJF from removing all trailing whitespace....

IntelliJ fails to build GJF due to ErrorProne+Java8

6

# Repro: 1. Load the pom.xml file in IntelliJ 2. Attempt to run tests inside IntelliJ Observe: ``` Information:java: An exception has occurred in the compiler (1.8.0_181). Please file a...

This shows how to use upb from Java. I don't expect this to be merged.

A space is inserted after slash-star /* comments

2

ktfmt emits the following: ``` f(43 /*bla */ ) ``` (when the max line width is short enough) Note the space between the closing `*/` and the closing `)`. This...