Chris Davies comments

Repositories
Issues
Comments

Results 4 comments of


                                            Chris Davies

fix(contentpicker): correctly clear old item when maxSelectable=1 and parent reloaded

CLA signed

fix(contentpicker): correctly clear old item when maxSelectable=1 and parent reloaded

> Roughly something along these lines might be better https://github.com/box/box-ui-elements/pull/1709/files. We still can use a map to prevent multiple find()s so that its a O(1) lookup or we can just...

fix(contentpicker): correctly clear old item when maxSelectable=1 and parent reloaded

@priyajeet: should be all set for another look on this!

fix(contentpicker): correctly clear old item when maxSelectable=1 and parent reloaded

@priyajeet should be all set from a code perspective. I changed `updateItemInCollection` to replace the matching item in the `selected` array. I do have a failing test though that seems...