Curtis "Fjord" Hawthorne
Curtis "Fjord" Hawthorne
Thanks for your contribution! A few requests: - Let's name the new file `README.ko.md` to be consistent with ISO 639-1 language codes and the file naming convention proposed by https://github.com/tiimgreen/github-cheat-sheet...
Hi @samar-fathallah. I agree that the error message is annoying (a few of our transitive dependencies have conflicting requirements), but the colab should continue to work even with the error....
Is this not covered by the sound libraries installation command above in the readme? ``` sudo apt-get install build-essential libasound2-dev libjack-dev portaudio19-dev ``` At what point do you get the...
Does the comment added in #30 address this issue?
I'm guessing it's because of this line: https://github.com/magenta/note-seq/blob/master/note_seq/midi_io.py#L32 If you reset that constant to its default, do you get the desired behavior? This is a little tricky because we need...
That seems reasonable. Where would be a good place to put the warning?
That would be great, thanks!
Good catch! Could you write a unit test to verify the fix?
I think you should be able to add it to rl_tuner_test.py fairly easily.
@hardmaru