Christian Fredriksson

Results 23 comments of Christian Fredriksson

No solution found. Still waiting for input from Istio devs This was found together with https://github.com/grpc/grpc-java/issues/9157. Perhaps @costinm who commented on that issue can take a look?

Unit tests are failing but this seems unrelated?

@snicoll thanks I was not aware this issue existed with HttpClient. But according to [JDK-8258397](https://bugs.openjdk.org/browse/JDK-8258397) then the current implementation with additional timeout on CompletableFuture will not help because it fetches...

My comment about inconsistency was a hypothetical one. I just happened across the code and reacted to that the same timeout was set twice in two different ways. Now it's...

A suggestion; use the non-async send without timeout, capture the input stream before returning it, and schedule a separate timer to interrupt the sending thread+cancel input stream on timeout? If...

I haven't looked into it yet but initial thought is to use the common scheduler used for CompletableFuture timeouts/delayedExecutor. A guess is that it's the same or similar to what's...

After looking some more into this. The non-async send() [just calls sendAsync()](https://github.com/openjdk/jdk/blob/7e11fb702696df733ca89d325200f2e9414402d9/src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java#L934) which in term returns [a custom CompletableFuture which can be cancelled](https://github.com/openjdk/jdk/blob/7e11fb702696df733ca89d325200f2e9414402d9/src/java.net.http/share/classes/jdk/internal/net/http/common/MinimalFuture.java#L104) to cancel the request. HttpClient [keeps track...

Cool, I'll sort it out after summer vacation.

> Please add unit tests. There [appears to be a test for this already](https://github.com/grpc/grpc-java/blob/6e25c03a7bd43c089e3fd770b39e4d4b52347a28/netty/src/test/java/io/grpc/netty/AdvancedTlsTest.java#L452) but that test is a bit moot because it doesn't actually test much (it sets INSECURELY_SKIP_ALL_VERIFICATION)....

@pruivo `jgroups.fd.port-offset` is still configurable though but only when using UDP. I updated the docs to state this, please take a look.