Christopher Fichtlscherer

Results 18 comments of Christopher Fichtlscherer

@gridley, thanks a lot for all your comments! I try to go through them and create a new commit. I would be very happy to make the pulse-height tally functionality...

Here already the smaller changes and suggestions incorporated. Thanks again to @gridley. I think it's much better already. I need some time for the tally filtering system. But I am...

Dear Paul, thanks a lot for your reply and your comments. That I try to answer all below. I will go through the code review criteria again. Sorry if I...

I changed it. I think we should do it like the first version you suggested (that's how I currently have it implemented): ```python ph_tally = openmc.Tally() ph_tally.filters = [openmc.CellFilter(...), openmc.EnergyFilter(...)]...

@shikhar413, Thanks a lot! I am actually very happy with an additional set of eyes to look over this code. I hope we can finish this soon. I am a...

I am sorry, the last weeks were pretty busy, I am on vacation right now. From the 1st of November, I will have more time for working on this again....

Yes, of course. I am happy if this can help anyone, but please be careful. I do not give any warranty. I think there is still a factor of 100...

Yes that's right. Thank you for remembering. I will close it.

> @cfichtlscherer has some super nice stuff too. Are you able to give any sneak peeks Chris? Yeah I used it to plot some weapon models. I think it would...

Update: Actually there were some warnings during the make process: ``` In file included from /home/gf737457/openmc-13.3/openmc/src/finalize.cpp(18): /home/gf737457/openmc-13.3/openmc/include/openmc/plot.h(102): warning #858: type qualifier on return type is meaningless const int id() const...