Peter L comments

Results 87 comments of


                                            Peter L

Allow Site ID to be more Generic

I was thinking have it generic, so you could use u32, usize, u64, i64, etc.. whatever you felt the need to be, but I guess a simple mapping may work.

Importing HTML with headings is not properly formatted

I've created a pull request that resolves this if anyone is interested https://github.com/ether/etherpad-lite/pull/2222

Rust Language Server support

I have tried that command but I get the following messages in the console along with a spinning wheel: ``` No grammar found for language: rust Measure request fail ```

replace askama_escape in favor of v_htmlescape

Lots of [`unsafe` in this lib](https://github.com/botika/v_escape/search?q=unsafe), while there is none I could see in askama. Is there any benefit here besides less dependencies? Is it faster to use?

ngProgress injected is not the service but the factory

I'd need to see your controller to find out what is going wrong You should inject the ngProgressFactory: ``` var MainCtrl = function($scope, $timeout, ngProgressFactory) {} ``` Then in your...

ngProgress injected is not the service but the factory

Yeah, it may be worthwhile as a note in the readme for upgrading. I have a feeling it was changed to allow multiple instances of ngProgress at any given time.

ngProgress injected is not the service but the factory

Yep, agree. This was before my time. Glad to have solved the mystery though.

Typescript definition file

Hi @vogloblinsky, Probably needs and update, mind submitting a PR?

Bower Install Warning

Hi Zephyrus, Can you submit a PR to address this? Thanks

CSS, remove position: fixed?

Hi @arlowhite is overriding the CSS not sufficient?