cemeceme

Pleasew does not handle relative paths correctly

1

When a relative path is specified for the `location` under `[Please]` in the `.plzconfig` file, running please through pleasew will fail to create valid symlinks in the specified location. For...

Allow modifying Eco.WebServer.Web.Startup before it gets used in Eco.WebServer.WebServer.StartWebApp

5

**Context on the current state** Currently, the CostCalculator mod (or more precisely ModUtils) has pre- and post-inject functions around the function `Eco.WebServer.Web.Startup.SetupStaticFile(IApplicationBuilder, PhysicalFileProvider)` function, in order to add additional entries...

ArgumentNullException when harvesting contracted plants with a shovel

1

Eco version: 9.6.3. When trying to harvest a camas bulb as part of a contract, the player gets kicked with the stack trace below. Harvesting other crops via picking, reaping...

Subrepositories and plugin settings inherited from root

4

This is not a specific issue and more of a general overview of the issues I have been having about subrepositories. I think this is best described by an example:...

github_repo will fail confusingly if the given revision downloads a file with a different prefix.

4

If a `github_repo` rule is used for a repo and the revision argument is set to something that doesnt exist, please will still download whatever the main branch is and...

Spaces in root path cause plugins to fail

4

If the current project being built contains spaces and it uses a plugin, `plugin_repo` will fail, as it cannot locate arcat. i.e. if the project resides in `/dir/with spaces/proj` will...

Duplicate sub-plugins make general commands fail

1

If you have a plugin/sub-repo that internally uses another plugin (e.g. the cc-rules) and also have the parent project use both of these plugins, then commands such as `plz build`...

Feature request: Support for "Configuration files"

2

In some languages, such as C, I have come across the convention of having a configuration file for libraries. This file contains some macro definitions and at times some small...

Race condition when depending on rules created in post_build.

2

Here is an example of a BUILD file with a post_build function adding dependencies: ``` def post_func(ruleName, cmdOutput): fileRule = text_file(name="postFile", content = "Some content", out="postFile.txt") add_dep(ruleName, fileRule, True) genrule(name="postRule",...

Added dependency check after post_build step.

1

Fixes the race condition for dependencies created within post_build steps #3168. The issue is that a target will mark itself complete, even though the post_build step could have added additional...