Cedric Donié

Results 13 comments of Cedric Donié

I also get the same error also for `GSPath` with version 0.6.5 on Python 3.6.15 (Ubuntu 20.04.4 LTS) through the following minimum working example. Interestingly, only iterating through the generator...

I just thought about deprecation while coding up PR #6373. This guide would have clearly answered my questions.

> Regarding DL classifiers and multiclass: I ran all tests with a scenario of three classes, no DL classifiers are failing. See #6376 > > I think this is because...

Hi, I hope that it's OK to comment on this issue again. As a user with a database on a personal OneDrive account, I would strongly favor`Files.ReadWrite.AppFolder` would as the...

> > However, I am sure that there is a substantial user base with KBDX files on personal OneDrives. > > @cedricdonie , I would assume most OneDrive Personal users...

I just had a brief glance at the former sktime-dl classifiers migrated to the sktime repository. It seems like the issue is fixed, but there is a potential footgun. I...

PS: I initially observed this problem when training InceptionTime https://github.com/cedricdonie/tsc-for-wrist-motion-pd-detection/blob/main/src/models/train_model.py and fixed it for myself via https://github.com/sktime/sktime-dl/pull/132. The dataset is quite large however, so it won't be trivial to reproduce.

Hi @fkiraly, after migration to sktime proper, https://github.com/sktime/sktime-dl/pull/132 is definitely not a valid fix anymore. Thus, I tried to understand whether this issue still remains in `sktime`, but would need...

> I would prefer `convert_y_to_keras` to be entirely private, that looks like the only way the estimator will be compliant with the general interface, among the four options you listed...

> Excellent! Would you then like to make a PR to `sktime`? Yes, I created PR #6373. > Recarding your comments: > > * yes, `_predict` should be fine, as...