Chris Dumez

> Hi @cdumez, > > There was a minor bug in the commit. The `Reporting-Endpoints` takes a structured header. The keys must not start with a number. The test is...

> @cdumez doesn't that mean we might have a bug in the parser? I have just looked at our implementation and it looks alright: ``` // Parse a key (https://datatracker.ietf.org/doc/html/rfc8941#section-4.2.3.3)...

> I believe this code snippet was taken from the `parseStructuredFieldValue` parser: https://github.com/WebKit/WebKit/blob/acb70b8a1be898aca87a6f4c402678b3993f7a4f/Source/WebCore/platform/network/HTTPParsers.cpp#L584-L614 > > But, I believe the `reporting-endpoints` might be parsed by a different parser in `ReportingScope::parseReportingEndpointsFromHeader`: https://github.com/WebKit/WebKit/blob/06d4a7261d9b1c77d142549bd8b41e10eb94972a/Source/WebCore/Modules/reporting/ReportingScope.cpp#L118-L156...

> > I believe this code snippet was taken from the `parseStructuredFieldValue` parser: https://github.com/WebKit/WebKit/blob/acb70b8a1be898aca87a6f4c402678b3993f7a4f/Source/WebCore/platform/network/HTTPParsers.cpp#L584-L614 > > But, I believe the `reporting-endpoints` might be parsed by a different parser in `ReportingScope::parseReportingEndpointsFromHeader`:...

FYI, we intentionally made this change in WebKit: https://bugs.webkit.org/show_bug.cgi?id=169296 The reason we made this change was because a newer version of bugzilla was not working in Safari but was working...

Looks like I merely filed a bugzilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1345270 and it looks like it is still open so I expect the issue to still exist in bugzilla. If so, browsers...

Well, we definitely had the bug when we updated our WebKit bugzilla instance. If you go to https://bugs.webkit.org/attachment.cgi?id=303712&action=review then right click > Inspect on the select "r:" element at the...

The exact steps to reproduce the issue were: - Go to https://bugs.webkit.org/attachment.cgi?id=299235&action=review - Press the "Preview button" - Notice that the "Review" / "Commit Queue" select element show a "X"...

Patch works great locally on both WK1 and WK2. However, it doesn't seem to work as expected on the bots. Not sure why yet :/

> Not familiar with cocoa API but overall this looks excellent, really happy this was doable for the Apple ports! It is working great locally but I am getting odd...