Connor Dietrich
Connor Dietrich
Thanks @jbogaardt. Seems to be a very useful/flexible implementation and a great feature of the package so I'm happy to help improve it. It's possible my second and fourth bullet...
Happy to contribute on this and suggest updates to the code. Do I need to be added as a contributor to push a branch for this?
I had a chance to spend more time with this and get a better feel for what the code is doing. Going to restate my suggestions since I think I...
If it helps - I notice this occurs frequently when changing the grain to quarterly with the `grain` method, with `trailing=True`. Also the` valuations` are potentially off as shown below....