cdhf

Results 17 comments of cdhf

With regard to the zoom lens example: The first problem seems to be the reference to the discontinued SFL4 glass. The replacement glass should be N_SF4. Right after that hovewer...

What if any surface could be a detector? Let's say that any surface can have an optional associated detector. After finding the next surface with surfaceintersection and closestintersection, the associated...

@BrianGun sure, why not. It's another good chance to understand the code base better.

@BrianGun This sounds very good. I have one more suggestion: I think it would make sense if not only the detector but also the surfaces would have a name field....

@BrianGun These are valid concerns. I'll open a separate issue for this.

@BrianGun I have a question regarding the update code for the HierarchicalImage in OpticalSystem at row 157-158: ``` pixu, pixv = uvtopix(detector(system), uv(detintsct), size(system.detectorimage)) system.detectorimage[pixv, pixu] += D(sourcepower(r)) ``` I...

@friggog Ok, this makes sense. I did not think of the interaction with the nondeterministic nature of the raytracing method, but of course Zemax is doing the same if raysplitting...

@BrianGun I fear I do not understand why this code should be wrong. In ReflectOrTransmit mode the code behaves like previously, randomly choosing reflected or transmitted ray according to the...

@BrianGun I understand this, but from friggog's comment above I understood that this is handled by the detector update code in OpticalSystem.jl, which ignores the instantaneous ray power completely and...

@BrianGun This sounds like the right way to do it now. It still bothers me that it is so easy to use the machinery wrong. In particular, if you do...