Clement de Groc

Results 15 comments of Clement de Groc

👋 Indeed, we've done some experiments internally using asynchronous requests to C* (i.e. removing `storage.parallel-backend-executor-service`). We have observed improvements on tail latencies and believe one of the reasons is that...

> Quick question: how is this PR related to #986? I don't think this PR can solve #986 alone. But `search_after` was mentioned in #986 as a (potential) step towards...

> How will JanusGraph behave if an index backend is configured and in use for some mixed index and the index backend is then removed from the config? Will it...

> Rather than this breaking change, add a `remove` API and add some Javadoc saying that removal of config might not work properly under all circumstances (e.g. index settings) so...

I could be missing your point, but isn't it because: 1. `ConfiguredGraphFactory.updateConfiguration(graphName, ConfigurationUtil.loadMapConfiguration(map));` updates the graph's configuration (within the `ConfiguredGraphFactory`) 2. `assertEquals("true", graph2.openManagement().get("query.batch"));` checks the global configuration (not the graph's...

> > assertEquals("true", graph2.openManagement().get("query.batch")); checks the global configuration > > Yeah, you are right. That's somewhat confusing, isn't it? We might want to document it otherwise people like me would...

An `IllegalArgumentException` is raised when a metric is [registered twice](https://github.com/dropwizard/metrics/blob/v4.1.18/metrics-core/src/main/java/com/codahale/metrics/MetricRegistry.java#L156). This only applies to metrics [added using the register method](https://github.com/dropwizard/metrics/blob/v4.1.18/metrics-core/src/main/java/com/codahale/metrics/MetricRegistry.java#L89). A number of new metrics were added to the `InstrumentedExecutorService`...

👋 Sorry for not answering earlier. I'll try to catch up and see if there's anything I can help with.

Created #4061 to address comments regarding the interface. Let me know what you think.

> I started to take a look at usage of this `backend-ops` pool and it seems to be used for multiQueries only when the underlying storage backend doesn't support multi-key...