Chuck Cadman
Chuck Cadman
> I'm sorry I'm not so familiar with the SQLAlchemy changes, but do you mind explaining why we should filter `RemovedIn20Warnings` instead of updating the code? I assume we want...
@datapythonista I agree with everything you wrote. I don't think we should censor `RemovedIn20Warning`. The only warnings filter I put into any code is this code in pandas/tests/io/test_sql.py: ``` if...
Update: pandas/io/sql.py will have to change significantly from how I currently have it in this PR.
@datapythonista I modified this PR's code, title, and original comment, and it is again ready for review. Since I am now testing 2.0-style sqlalchemy connectables instead of checking for warnings,...
@mroeschke I haven't seen a release date for sqlalchemy 2.0. Instead of duplicating all the tests, I could make the `future` argument of `create_engine` depend on either a global constant...
I'm planning to make some changes to this PR. Firstly, I noticed that pandas.io.sql.execute is documented, right above this line: https://pandas.pydata.org/docs/user_guide/io.html?highlight=sql%20execute#engine-connection-examples . As it stands, my PR would make this...
@datapythonista @mroeschke Based on your feedback, I took out all the test duplication, and instead ran the tests with sqlalchemy 2.0.0b2 installed to ensure that this can close #40686. This...
@mroeschke As a pandas/sqlalchemy user, it would be really helpful to get these changes into pandas sooner, so that I can get my code ready for sqlalchemy 2.0 sooner. This...
@tiangolo , I find this package very helpful to complement typer, and I hope this PR will help keep it up-to-date. The hard work was already done in the typer...
@jimmywan , I noticed that @tiangolo has done some recent work in the typer repo, but I haven't heard from any typer-cli maintainers regarding this pull request. I also just...