Christopher Joel

Results 221 comments of Christopher Joel

On the rs-ucan side, it would be trivial for us to omit these fields when they are not used. It would probably be better to omit them as it improves...

As an optimization/mitigation, I changed rs-ucan's serialization to omit these fields when unused: https://github.com/cdata/rs-ucan/commit/7203f324998791ea91d3aa8c5f5d0d05a6600d1c Published as https://crates.io/crates/ucan/0.5.0-alpha.6 Tokens generated by rs-ucan are now accepted and interpreted correctly by the validator...

FYI in Git HEAD only `Cid` is re-exported. `cid::Codec` is not, and this makes it very hairy to construct a `Cid` from outside the crate.

Looks like https://github.com/matrix-org/matrix-doc/issues/772 and https://github.com/matrix-org/matrix-doc/issues/1468 were just closed today.

This is a bug in how we currently match media types (aka mimes). Basically "vnd...+" clauses will throw us off and prevent us from detecting file extension/mime relationships correctly.

Copying over from Discord for posterity: > I've been going pretty deep on media types in the last few days. One thing that has come up for me is that...

Thanks for the thorough report! I will take a look.

/cc @valdrinkoshi this is relevant to the overlay "final solution"

For reference: https://github.com/ucan-wg/rs-ucan/issues/25