Christopher Joel

Results 221 comments of Christopher Joel

If we have a "blocking" storage implementation, the level of abstraction where I would like to deal with that is outside of the storage implementation itself. That would give us...

The builder pattern is most suitable in cases where the following conditions are met: - There are a lot of fields that are needed to initialize a struct - Some...

What utility does a user of this interface get from the intermediate stages of construction being exposed here?

> in reading the code, proof chain creation from string/CID seemed to make the store and parser as implicit side effects. I think you may be on to something, but...

Yah, I like that idea. Maybe we should cross-file this against `rs-ucan`...

Seems like a reasonable feature for us to add :+1:

Copying here what I wrote in Discord for posterity: > Sorry, this should have occured to me. I knew we weren't setting those headers in Noosphere (though maybe we should.....

Ditto, just made the same changes myself before checking the PRs :'( hopefully the maintainer is still around?

BTW, the migration guide also suggested changing `millis()` to `Kaleidoscope.millisAtCycleStart()` ([reference](https://github.com/keyboardio/Kaleidoscope/blob/master/UPGRADING.md#kaleidoscopemillisatcyclestart)) It was a trivial change: https://github.com/ToyKeeper/Kaleidoscope-LED-Wavepool/compare/master...cdata:master

The scope of JS packaging is somewhat narrow compared to packaging in general, and with that in mind it can pay off to have opinions. We don't currently have a...