Christian Convey

Results 19 comments of Christian Convey

FYI, due to work schedules, @csullivan will follow up with any issues / suggestions I raised in my reviews. I'm happy to for this to be merged once @csullivan Approves.

Summary for 2022-08-22 to 2022-08-29 |Run|Commit|Mitigation| |--|--|--| |[tvm-ci/branch](https://ci.tlcpack.ai/job/tvm/job/main/4158/display/redirect)|1afd0593956066635ee49297b731726c9218c91c from #12340|Checks API failure (https://github.com/apache/tvm/issues/12602)| |[tvm-ci/branch](https://ci.tlcpack.ai/job/tvm/job/main/4149/display/redirect)|90b2f0d36996be10d71f0c923f588c6dfa0e8546 from #12557|maven problem (https://github.com/apache/tvm/issues/12601)| |[CI / Android](https://github.com/apache/tvm/runs/7983481668?check_suite_focus=true)|8174d082e8168db9ad63826c9d68aee8c76c7090|android_rpc build failure (https://github.com/apache/tvm/issues/12599)| |[tvm-ci/branch](https://ci.tlcpack.ai/job/tvm/job/main/4144/display/redirect)|13ebbfb37f8cec1da71d88fbcbecdd4ad4d24dcc from #12562|Deploy docs failed to...

@jverma-quic : Could you please click the "Ready for re-review" link next to my name? I think that might be necessary to separate my old vs. new review comments.

This PR introduces several TOPI-related functions (`qnn_avg_pool2d_compute` and `qnn_avg_pool2d_schedule`). Does this PR make these functions available for compile-time consideration by TOPI? I'm not very familiar with the mechanisms TVM uses...

I find this function helpful for my own development work. I'm not positive that `tvm/support.py` is the best home for it, but it would be nice to have it around.

@areusch : This seems like the kind of thing you'd have thoughts on :)

CC: @Lunderberg @JosephTheOctonaut

@JosephTheOctonaut @Lunderberg : mind reviewing?

@JosephTheOctonaut @Lunderberg : Feel free to only give cursory reviews on this. It's mostly meant as a rough roadmap. I expect each individual unit test to need a little cleanup...

Note to self: consider renaming "call_tir" to something else, e.g. "call_tir_subroutine", to avoid confusing overlap with Relax's "call_tir" token.