ccollins476ad

(Regarding the new API in https://github.com/thiagomacieira/tinycbor/tree/dev) Just a question - how would you expect `get_string_chunk()` to be used with chained buffers? ``` static CborError get_string_chunk(CborValue *it, const void **bufferptr, size_t...

Thanks for the explanation, Thiago. It makes sense. When you say the `transfer_string` callback can "do nothing", it should still add the offset to the reader's internal pointer (or offset...

OK, thanks. I think there might be an issue if the `transfer_string` changes the opaque reader object. I am not especially familiar with tinycbor, so forgive me if I am...

Thanks @simonratner, that is an interesting idea. I'm wondering if the test package is the best place for the custom command to be specified. Ideally, a unit test would continue...

Anonymous structs and unions were added in C11. I agree that conforming to an older specification improves portability, but C11 is already seven years old! :)

I think achieving ISO C compliance will be quite a challenge. The nimble codebase knowingly uses quite a few gcc/clang-isms (e.g., `__attribute__((packed))`). Standards conformance is certainly a good thing, but...

When constructing the version string, the firmware intentionally excludes the build ID if it is 0: ``` int imgr_ver_str(struct image_version *ver, char *dst) { if (ver->iv_build_num) { return sprintf(dst, "%u.%u.%u.%lu",...

Thanks, oresk. Unfortunately, I don't think newt can escape paths with spaces. I tried to fix this earlier, but encountered an issue with gcc's dependency generation (`.d` Makefiles). Newt makes...

I think newt's handling of `pkg.cflags` isn't ideal. Here is what newt does: 1. ``` // Populate the base set of compiler flags. Flags from the following // packages get...

@dwld I wonder if this could be a Windows-specific issue you are seeing. Do you think you could show an example without redacting any paths? Unfortunately I don't have a...