Darin Webb

Results 54 comments of Darin Webb

> The high-level approach sound great and the testing strategy makes sense, but it's not clear to me how much risk this change carries. What would the consequences be of...

resetting your review because there are some issues I'm working out

There are a large number of modifications listed for prod: ``` Pending update for stack `autoscale-prod`: Modify AMIac233 [Custom::AMIManager] Properties Replacement: Conditional (InstanceId) Modify ASGCount [Custom::CountASG] Properties Replacement: Conditional (LaunchConfiguration)...

Found the issue - the `indent` function was adding extra spaces, which was editing some userdata scripts. Validating for production now also shows no changes.

Example of generated template: input ``` ./domain_redirect.sh -t https://cvent.me/7VYB42 -d csedcon.com,csedcon.net,csedcon.org ``` generated template: ``` --- AWSTemplateFormatVersion: 2010-09-09 Description: Provisions domains & subdomains that need to redirect to other domains...

Hey @KatieShipley, @sureshc mentioned that you're using `oj` because of some weird behavior in the `json` gem. Looks like that might be improved with the new version that @Hamms is...

Too many conflicts to easily resolved, needs a dedicated chunk of time too just reimplement this in a new branch off staging.

reopening this, for review once we get some in-flight DCDO fixes out.

Is the removal of `prompt` because of PII or lack of usefulness? Should `ai_response` also be removed? Link to model/schema reference: https://github.com/code-dot-org/code-dot-org/blob/8203e3d073f726b11ec5b11aaebb97976a8914a4/dashboard/app/models/ai_tutor_interaction.rb