Casey Provost comments

Results 11 comments of


                                            Casey Provost

Email_spec causes rspec to fail (though not under Spring)

👍 I am still getting this error with the proposed fix above in Rails 5.0.0

How can we refactor our code?

@shakeelmohamed are you looking to move zap-common into a Bower module that you can then import?

"included" key missing from response when object is same type

@dduqueti Check out these gists: * https://gist.github.com/caseyprovost/f1e7cc2348d8d64b8665a88c4f68099f (pagination logic) * https://gist.github.com/caseyprovost/d72997fbada92ee6d77313cff5e1c470 (using pagination logic)

"included" key missing from response when object is same type

@dduqueti Join the slack channel and DM me :) I can help you through this. Slack -> https://join.slack.com/t/jsonapi-suite/shared_invite/enQtMjkyMTA3MDgxNTQzLWVkMDM3NTlmNTIwODY2YWFkMGNiNzUzZGMzOTY3YmNmZjBhYzIyZWZlZTk4YmI1YTI0Y2M0OTZmZGYwN2QxZjg

callback_url definition

+1 sameissue here

Rails 5.0.1 placeholders are not working

I also get this for all or most queries. It prevents the Rails app from starting.

Unnecessary saves called on ActiveRecord belongs_to relation

@zpencerq I believe these persistence calls are wrapped in a transaction so performance impacts should be negligible. However, I am happy to dig into the logic if it is causing...

Flapping specs caused by timing issues with AJAX

I am seeing this behavior as well. Do we have any fix available or methodology of writing ajax-based tests so that they work more reliably?

Input values are reset on going back/forward

@adrienpoly I still see this issue in 3. I can reproduce 100% of the time by first doing pagination on a list (which uses turbo frames) and then click the...