carlfriedrich

Results 135 comments of carlfriedrich

@junegunn Thanks for commenting on this. So the preview window not showing when using `{q}` while it's an empty string is indeed a bug? Will you take care of this...

Ping @junegunn. Can I help with this issue anyhow? If this in indeed a bug, I would love to have it fixed.

@junegunn Thanks for your reply. So what are the different ways you see for this?

That sounds reasonable and would work for my use case. Are only those placeholders evaluated which are used in the preview command?

Great, than this approach would totally make sense, without breaking anything. Can I help with the Implementation?

I came here after I stumbled upon the fact that diff-so-fancy neither supports hex colors nor git's default color attributes `dim` or `ul`. This feels quite unintuitive, since the colors...

I just realized that cherry picking multiple commits probably won't work anymore with my change. Will check and fix that later.

@wfxr @cjappl Hmmm, I fixed my issue with multiple commits, but shellcheck is not happy. It wants me to wrap my `commits` variable in double quotes to prevent word splitting....

I tried using an array as well, gives another error: https://github.com/wfxr/forgit/runs/7706380924?check_suite_focus=true

Nevermind, following [SC2086](https://www.shellcheck.net/wiki/SC2086), [SC2207](https://www.shellcheck.net/wiki/SC2207) and [SC2031](https://www.shellcheck.net/wiki/SC2031) I found a way to make the linter happy while the code still works. 😄 Tested in bash and zsh.