Yue Wang
Yue Wang
AppConfig depends on the field path from ScopeDefinition's `spec.workloadRefs` to pass workload references to scope controllers. So if that field is missed, AppConfig controller is supposed to return error. It's...
Miss a required field when creating a HealthScope ``` apiVersion: core.oam.dev/v1alpha2 kind: HealthScope metadata: name: example-health-scope spec: workloadRefs: [] #
`VolumeTrait` changes the type of a workload's child resources, which may result in an unpredictable impact or breaking changes on current trait&scope interacting with those child resources. If traits&scopes are...
Maybe I can help, could you plz assign this issue to me?
> use APIUpdatingApplicator instead of APIPatchingApplicator > https://github.com/crossplane/crossplane-runtime/blob/v0.10.0/pkg/resource/api.go#L178-L208 > > crossplane-runtime 0.9.0 -> 0.10.0 thx for your kindly suggestion!
Server-side apply can solve this problem after k8s v1.19. Before 1.19, it doesn't remove field in such a case shown [here](https://github.com/oam-dev/kubevela/blob/eb9a76c2d1547a0f9668bac5f2582839d8be83a2/pkg/utils/applicator/apply_resource_test.go#L97)
SS apply this deployment ```yaml apiVersion: apps/v1 kind: Deployment ... spec: replicas: 3 template: spec: containers: - name: nginx image: nginx:1.14.2 ``` SS apply below with the same field manager...
working on this [PR](https://github.com/oam-dev/kubevela/pull/857), refactor `apply` mechanism to compute a three-way diff in client side, just like how `kubectl apply` does under the hood, the last-applied-state is stored in annotation.
@allenhaozi A possible workaround: maybe the ServerWorkload controller should show no opinion on `.spec.replicas` when create/reconcile a Deployment, leaving `.spec.replicas` to ManualScalerTrait, just like [how ContainerizedWorkload controller does](https://github.com/crossplane/oam-kubernetes-runtime/blob/4d8be8c1c63b21167fe58a1d63a8cc70ff7baf1e/pkg/controller/v1alpha2/core/workloads/containerizedworkload/containerizedworkload_controller_helper.go#L33). But of...
It comes across with below confusing scenario. Here's the schematic of a Component ```yaml apiVersion: core.oam.dev/v1alpha2 kind: Component metadata: name: example-component spec: workload: apiVersion: core.oam.dev/v1alpha2 kind: ContainerizedWorkload spec: containers: -...