Dennis Scheiba
Dennis Scheiba
Bump - what is missing for a merge?
> Would it be possible to change this so that it _only_ provides clang-format? So something like a [virtual environment](https://realpython.com/python-virtual-environments-a-primer/) in python where certain environment variables to paths of binaries...
> A quick search about this provides some clues about `docker exec` or `docker exec -i`. Are you sure it's not possible to use it as if it was just...
> I don't have any contrargument for this, with my limited experience. But if it could be used the way I descried bearlier, I'd still consider it. I mean you...
> Couldn't we do something like `export SC_CLANG_FORMAT="docker exec blah"` and have the scripts work with it transparently? Wouldn't that solve the need to mount files within the container? Well...
I created a new branch https://github.com/capital-G/supercollider/blob/init-pre-commit/.pre-commit-config.yaml where clang-format is managed by a pre-commit hook, making the format scripts obsolete? I could not use 8.0.1 so I updated to 14.0.6 (see...
> After the dev meeting on 2022.09.11 I think we'd like to explore a possibility of upgrading the clang-format version that we use before considering this PR. Thank you for...
Thanks for the feedback @scztt - do you think the additional commits are sufficient? if so, I'll start to write docs for it :)
Updated docs
Added tests, but not all tests are passing, e.g. ```supercollider FAIL: a TestCoreUGens: test_ugen_generator_equivalences - "Duty.ar(SampleDur.ir, 0, x) == x" 1 of 48000 items in array failed to match. Displaying...