Cameron Rutherford
Cameron Rutherford
Can this be merged? I don't see any reason why this is still blocked
@tcojean I have applied your suggestion and the changes seem to function well, thanks!
@alalazo I addressed your changes - I forgot to fix that after applying @tcojean's patch. #32469 introduced a breaking change in camp for `HIP_CLANG_INCLUDE_PATH` that I noticed when building RAJA/Umpire,...
This is one of my smaller spack PRs, but the review has been very insightful. Thank you all who helped! I think this is finally ready for merge.
> It looks like this PR makes `@1.5.0.glu_experimental` the default -- is that the intention? > > > > I see the only failing CI check is due to `[email protected]_experimental...
Should I just change the default for ginkgo for the moment while this branch is experimental, or do we want to keep this PR open to debug the rocprim issue?
Set `preferred=True` for version 1.4.0. Hopefully, that fixes pipelines.
I think this is good to go
cc @fritzgoebel
https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/hiop/package.py Currently it is valid to build `hiop+ginkgo+cuda` or `hiop+ginkgo+rocm` in the spack package. I think this is what @fritzgoebel was building recently, and so we might want to tweak...