Camden Cheek
Camden Cheek
> needs changelog entry, yes? ah, yep. I've got some changelog debt from predicates changes. > closes https://github.com/sourcegraph/sourcegraph/issues/24325 yes? Sure enough. I forgot we had an issue for this
Re-requesting review because this got a little stale and getting it updated required non-trivial changes.
Ooh, great idea to put this in `sg`. I think that would be much lower lift than a site admin page, but would be a huge QOL improvement
I get a backtrace that points me to `Texture2dMultisample`. ``` ❯ RUST_BACKTRACE=1 cargo run Finished dev [unoptimized + debuginfo] target(s) in 0.15s Running `target/debug/art` thread 'main' panicked at 'gl function...
Hi @AntonHermann! Glad to hear you find it useful. Sorry I'm just getting back to you -- somehow I missed the notification for this. Anyway -- I totally agree that...
FYI, I've been pushing changes relevant to the [other PR](https://github.com/sourcegraph/zoekt/pull/367) back down to that PR and rebasing this on top of it so "what is mergeable now" and "remove stuff"...
There is no external scanner for the Dockerfile grammar, only code generated by the `grammar.js`
Hi @kopecs! Thanks for the report. When you say "attempting to parse the file", how exactly are you doing that? When I run `tree-sitter parse` on a file with that...
Oh, sure enough, a fresh clone reproduced this. Turns out my `main` branch wasn't up to date 🤦 The "doesn't handle newlines" part of this is almost definitely a bug...
Thanks for the report! I just pushed [a commit](https://github.com/camdencheek/tree-sitter-dockerfile/commit/28ac8596bab00b2dac9a76deaa9c4cb2b22642fd) to `main` that should fix this issue.