Gabriel Camargo

Results 14 comments of Gabriel Camargo

> The basic concept of this pull request is understandable, but such a change must also be reviewed from a security point of view, as the modifiability of serials belonging...

> > This PR adds a new function to edit the serial of a specific account. Currently, when players change their PC, the server owner needs to shut down the...

> Is there any particular reason why this function uses an account name instead of an account element? I tried following the setAccountPassword and setAccountName pattern But I don't have...

> Why would they need to shut down the server? You can login into the account from 5 different computers without issues. > There isnt one serial per account. Accounts...

> > Let me try to give a better example. I don't use ElementData and I only use the Multi Theft Auto login system. I create a simple `if getAccountSerial(account)...

> acl.xml have no effect on client side functions and events. It only prevents server side code from doing stuff. > I see no reason why this function should be...

> > But this function is on the server side > > I understand that. I was responding to > > > what we can do to increase security is...

> > This function would still be useful if you're just looking to update the serial returned by getAccountSerial. It does raise another question - should getAccountSerial be returning the...

> @camargo2019 please resolve old conversations as they widen the page 😅 @TracerDS done 🙃

> Do we still need to add `setAccountSerial` to [acl.xml](https://github.com/multitheftauto/mtasa-blue/blob/master/Server/mods/deathmatch/acl.xml)? I believe it would make sense. What do you think? Should we add this function to the acl.xml?