Cal Pratt

Running into the same issue. I've been able to hack this to work with the following workaround: ```python @dataclass class Inner(DataClassJsonMixin): a: str @dataclass class Inner(DataClassJsonMixin): a: str @dataclass class...

FWIW you used invalid ascii. you need `'` instead of `‘`

> Sounds reasonable. Renaming src to rapidgzip (and adjusting CMake) seems sufficient to implement this, right? And updating the paths listed in the include lines. i.e. `#include ` -> `#include...

Ah, thanks for the clarification. For the namespacing, maybe something like this?: - core -> `namespace rapidgzipcore {}` - indexed_bzip -> `namespace indexedbzip {}` - rapidgzip -> `namespace rapidgzip {}`...

Sounds good. I'll need to get approval for contributing to the other repo, but I can start in off of this fork. I can issue them over there if you...

Another question, I noticed you also have a `bzip2` namespace in `src/indexed_bzip2/bzip2.hpp`. Should I leave that alone or move it to `indexed_bzip2`?

> It would probably be the more natural and less intrusive choice to move everything in rapidgzip::core into rapidgzip :S Was thinking about that yesterday as well! I think that...

@mxmlnkn I cleaned up the PR to have core included in rapidgzip namespace. Only a few spots needed additional prefixing now. One thing I did have to change was the...

Alternatively, would using `GzipBitReader = BitReader;` and `BzipBitReader = BitReader;` make more sense?

> The other template argument is much more meaningful, at least to me, i.e., BitReaderLSB vs BitReaderMSB or much better gzip::BitReader vs. bzip2::BitReader because this naming is more teleologica Added...