caglayantuna

I am not sure how to fix but I can give you an idea. It seems that Keras converts `EagerTensor` to `Tensor` and `Tensor` object doesn't have ndim function as...

Hi, could you share your code? It would be better for me to understand your issue with sparsity.

Maybe, we can add `fill_diagonal` function to tensorly if we can find a suitable way for all backends. [Numpy](https://numpy.org/doc/stable/reference/generated/numpy.fill_diagonal.html), [pytorch](https://pytorch.org/docs/stable/generated/torch.Tensor.fill_diagonal_.html) and [tensorflow](https://www.tensorflow.org/api_docs/python/tf/linalg/set_diag) have already related functions. For [jax](https://github.com/google/jax/issues/2680), there is...

For `validate_tucker_rank`, should we multiply [n_fixed_params](https://github.com/tensorly/tensorly/blob/f7d326125aaa4067887a52d6e84dbd7750945561/tensorly/tucker_tensor.py#L372) with x. It solves sign issue but [assertion issue](https://github.com/tensorly/tensorly/issues/288) remains arbitrarily.

Thanks for the issue. While `a_max` in [tensorly.clip](http://tensorly.org/stable/modules/generated/tensorly.clip.html#tensorly.clip) is None as a default, it requires an input for [numpy.clip](https://numpy.org/doc/stable/reference/generated/numpy.clip.html). One solution for your issue is to add `a_max=None` to `tensorly.tenalg.proximal.soft_thresholding`...

You can format your files with Black. Then, it will pass the test. To use Black; ``` pip install black black filename.py ```

This is what I see with chrome on Mac.  No issue with Safari. 

Thanks for your answer and suggestions. When we start thinking about benchmarks with @cohenjer, our target was to provide customization to the users. People can use their own dataset or...

Yes, appending more methods and adding append kwargs option make sense. I will edit the functions accordingly. I would be happy to make the code more general but `component_comparison_plot` is...