Aleksey Bykhun

Basically, all these is presetup-babel + dev server. It's nice to have this published as a collection of cli-scripts, so I'd use it like this inside my React project: ```javascript...

- **Version**: commit: "", repo: 7, version: "0.32.3" - **Platform**: Chrome, Mac OS X Mojave (but bug happens on other platforms: Windows, Yandex Browser) - **Subsystem**: pubsub #### Type: Bug...

TODO: still requires forking mainnet to run tests ``` FORK=true hh test ```

erc20 token pass extension

1

Feature request: Allow to mint specific ERC20 holders that has min balance. **Warning!** No protection against transfer-and-mint

metaverse-nft: not allow contract to call mint()

4

_speculative._ https://www.reddit.com/r/ethdev/comments/8r6b93/is_txorigin_msgsender_a_secure_option_to_prevent/ TODO: - [ ] estimate how many users minted using multisig - [ ]

NFTExtension interface conformance doesn't check anything

1

Given `INFTExtension` interface is empty, the ERC165 check for that is always true. https://github.com/buildship-dev/nft-contracts/blob/2f33f71c05266b45b1f1e3fb80e421087dd8f5b7/contracts/factory/extensions/INFTExtension.sol#L6-L7 Which means `addExtension` check doesn't check anything: https://github.com/buildship-dev/nft-contracts/blob/2f33f71c05266b45b1f1e3fb80e421087dd8f5b7/contracts/factory/MetaverseNFT.sol#L201-L205

Being perfectionist, I could not pass by ## BEFORE  ## AFTER 

whitelist: check backend if address is in whitelist before requesting

1

whitelist: check backend if address is in whitelist before requesting