Periwink

Results 256 comments of Periwink

As a side note: do ranking metrics work with the current masking simply because those metrics are not affected by makes values where `y_pred = ln(1e-10), y_true=0` ? Wouldn't it...

I'll try to work on this; probably will start with an API that's very similar to pytorch

I'm skipping the computation if there are 0 relevant documents (any(truths) is False), since the metric is undefined. For a single input, where truth = [1], I would expect to...

HI jerome, you are right, I made a mistake. I'm using the definition on wikipedia It looks like the results would be 0.0 if the document isn't a relevant one...

I'd like to learn more about derive/macros, I'd be happy to work on this

Looking at other procedural macros, it looks like I would have to change a bit the structure of the repo? Seems like procedural macros have to be in their own...

I also tried to implement it as a trait; similar to Broadcast/Reduce: https://github.com/coreylowman/dfdx/pull/298/files I'm also kind of stuck because i'm not good enough at Rust. Would this kind of solution...

Just mentioning that this crate: https://github.com/abnormalbrain/bevy_particle_systems is a good example of CPU particles. (however particles are spawned as separate entities)

Ah I didn't know about `EntityMut`; I was able to make it work with `EntityMut`! I think it would be nice to improve the documentation on: - which SystemParams are...

> instead of documenting it, could we make it work by checking against `plugin_name_added` in `is_plugin_added`? I made the change; if that sounds good, I can update the PR description