Byron Wolfman
Byron Wolfman
> What do you think about using a pattern detection strategy instead of explicit toggle? If the string begins with `@` use the `self.username` verses strings starting with `U` use...
Hey! Sorry for not following up on this sooner; it's been a bit of a crazy month/months/pandemic. The internal team ended up forking errbot to achieve their outcome. It turns...
Hey so I've run into some design issues and have to come out of the rabbit hole. The main issue is that the `SlackPerson` object and that `Person` object it...
It's certainly possible to add a new method to `Person` but I'm not sure where it would be called. Perhaps in `get_acl_usr`? It could work, but it would probably also...
~Right, so, I've just tested this and it appears to work, but it requires changing the signature of `SlackPerson`'s initializer:~ Expand! ```diff - def __init__(self, sc, userid=None, channelid=None): + def...
Ok pretty sure I've figured out a non-terrible way of making this work without breaking stuff for existing users; new commits incoming!
Thanks everyone for your patience. I've pushed some new commits and have re-written the opening PR notes to describe the new changes that will detect user IDs vs usernames at...
I noticed that https://github.com/errbotio/errbot/pull/1416 has since been merged and so I'm looking for some more guidance here... should these ACL changes be added to the `slack_rtm` backend as well? There's...
> I wouldn't worry about that other pr. If you could add these acl changes to the slack rtm that would be good Thanks @sijis. I've rebased against master and...
Hey! The clutter (and requisite apology) is all on me. :) As far as contributing goes, all that's left to do is to have this merged/approved by @sijis -- or...