Bartlomiej Plotka
Bartlomiej Plotka
Yup, CI is NOT running this generative script. We only check if metrics given by the runtime is what we expect in those generated _test files and then complain with...
BTW.. we have two of those scripts 🙈 https://github.com/prometheus/client_golang/blob/main/prometheus/gen_go_collector_metrics_set.go https://github.com/prometheus/client_golang/blob/main/prometheus/collectors/gen_go_collector_set.go
This might need proper refactor e.g. have one generated set in internals and separate logic to filter those for test purposes (it's just regex)
Ideally I would also have only one script that generates both package files 🤔
## Acceptance Criteria * One script to generate test helpers for two places, we can move it to scripts dir or so. * Make sure our CI job for periodic...
Nice, let's review benchmark code https://github.com/prometheus/prometheus/pull/15083 and will check this PR out for review/efficiency assessment 👍🏽
Thanks for raising. This is a valid use case although I am quite surprised that one would want to put summary for HTTP requests (we generally discourage summaries, given native...
FYI there are 2 other attempts for similar part of code: https://github.com/prometheus/prometheus/pull/6129, https://github.com/prometheus/prometheus/pull/8205
👋🏽 Moved to draft, since there are some comments to address, but otherwise it would be nice to have this! Thanks!
Do you have some pprof of compactor we could take a look? What's so expensive in allocs in this change?