Bartlomiej Plotka comments

Results 932 comments of


                                            Bartlomiej Plotka

data race in TestOnlyProviderStaleTargetsAreDropped

Fix https://github.com/prometheus/prometheus/pull/15634

data race in TestOnlyProviderStaleTargetsAreDropped

Another attempt https://github.com/prometheus/prometheus/pull/15637

[release process]: Do release candidates

First question, what's wrong with multiple patch releases? Having multiple patches, especially as many have upgrades automated, might be not that bad. Second, who will commit the time to try...

[release process]: Do release candidates

Similar, but non-conflicting idea https://github.com/prometheus/client_golang/issues/1648

feat(conf): add optional field_labels to override Labels

Also please rebase as we updated CI.

Update expfmt/text_parse.go to support the new UTF-8 syntax

👍🏽 Thanks!

Optionally return error if two metrics would collide under escaping schemes

> Hypothetically, if a system defined two metrics that are different in UTF-8 but the same when escaped, the escaped text exposition would show two entries for the "same" metric....

Optionally return error if two metrics would collide under escaping schemes

I also don't get https://github.com/prometheus/client_golang/pull/1641 goal. I thought this issue is to fail on registration, which is generally best-effort (e.g. there are cases of unchecked collectors etc) and that's fine....

Optionally return error if two metrics would collide under escaping schemes

Thanks, makes sense! > I also think maybe we should go back to failing at registration time since that's when the other collisions are caught. The trouble is that creates...

[meta] Changelog Automation

Don't think it's completed ![image](https://github.com/user-attachments/assets/21833f06-6b90-4ab8-b3c8-3bb7e72459cb) Did you mean to close as not planned @ArthurSens ?