Brian Wilkerson

Renaming a named parameter in a function type ignores uses in argument lists

1

Given the following: ``` void g(int Function({int x}) f) { f(x: 2); } ``` If you rename the `x` in the parameter list to `y` you get: ``` void g(int...

Dead code enhancement in logical expressions

6

Given a file with the following: ``` void f() { print(true || false); print(true && true); } ``` The first line is flagged as having dead code, but the second...

Possible memory leak in use_late_for_private_fields_and_variables

5

The visitor for `use_late_for_private_fields_and_variables` defines two static fields. They are used to keep track of information across visitors when a library has multiple compilation units (that is, has parts). While...

Check the variable type in prefer_typing_uninitialized_variables to account for type inference

3

Under null safety it will sometimes be possible for local variables without a type annotation to have a type inferred for them even if they don't have an initializer. This...

Poor handling of adjacent strings in annotations

2

The `@Deprecated(...)` annotation takes a string that describes what to use in place of the deprecated element. When that string is long, authors will sometimes use adjacent strings to break...

Document using Never for methods that never return

2

In this section of the null safety doc (https://dart.dev/null-safety/understanding-null-safety#top-and-bottom), in the last bullet item, consider mentioning one use case for `Never`: using it as a return type on methods that...

Dead code diagnostic has wrong highlight range

5

The dead code analysis in the analyzer produces diagnostics with the wrong highlight range in at least two cases. Create a file in a package that will be analyzed with...

Lint when an explicit type would be inferred

8

It would be nice to have a lint to flag code where an explicit type annotation is provided that is unnecessary because the same type would be inferred if the...

Add lint to find uses of end-of-line comments where doc comments were likely intended

3

It would be nice to have a lint to catch cases like the following ``` // method comment void m() {} ``` There might be too many false positives, although...

Add a lint when defining default values for optional parameters

21

Default values for optional parameters - break forwarding in ugly ways, - pollute interfaces in confusing ways, - become part of the signature of the method so that it affects...