Branden Vandermoon
Branden Vandermoon
> > LGTM. Re: `No functional change, rely on presubmit test.` > > Is there a presubmit test that will test what you need here? Or do we need to...
> Thanks Samuel. Could you please also run a training for both of the `MODE` options being updated here? As well as with/without explicitly setting `JAX_VERSION`? It would also be...
Thanks for bringing this up @SamuelMarks. A couple questions/comments: 1. For the end_to_end piece, what would be the benefit of a Python rewrite? 2. Benchmarks could be interesting to split...
> Can we add some unit test here protecting this? Just running this code without asserting anything is fine +1
@SamuelMarks @lukebaumann what is the issue with the `~`? Generally the runners look for xpk to be present in the users's home directory at `~/xpk`. For example the benchmark runner...
> > @hsuan-lun-chiang do you have train profiles for this run? I see some issues with the Jetstream profiles, maybe they were started before the actual requests started happening? >...
> > How is the correct GCP project info picked up? > > The ML Run (managed profiler UI) is always created under the project / regions where the workload...