buzzingwires
buzzingwires
@burny0202 A few things: Firstly, in order to restore a detached label, you will need to invoke label repair with `-u`. `-c` can also be added to fix checksums (which...
You're welcome! I'm glad you generally like how this is turning out. You have a good weekend, too! I most-certainly will investigate the bug. I am not *immediately* able to...
Think I fixed our race condition and understand why it happened. Fixing this also removes the need for the redundant check for rendered thumbnails in the tests. See 15610c3be365d3393555efc6548ce8eb1404c9df
Hmmmn, now we have one of the tests passing on my machine, but failing on the remote. I think what's happening is that moving pruning inside the thumbnail creation callback...
I haven't quite figured this out yet, but my findings thus far are: * Changing the number of threads (by means of `pool.setMaxThreadCount()`) does indeed affect which thumbnails are pruned....
Leaving my notes here: The number of images to be loaded being less than the number of threads set for the pool is what seems to cause this to happen....
Rewrote the tests as specified and ended up removing the test for a thumbnail at a specific index, because that's really the only part that's non-deterministic. There wasn't really a...
Of course! I'm glad you're ultimately happy with the way this is turning out. If I recall correctly, I originally tried to do the pruning after scrolling, but there was...
https://github.com/karlch/vimiv-qt/commit/15610c3be365d3393555efc6548ce8eb1404c9df I also just tested moving the `_prune_icons()` call again just to make sure. That said, `_prune_icons()` could perhaps be optimized further. A low-hanging fruit might be to skip if...
By the time you sent your post, I honestly had already just about implemented the low-hanging fruit of checking if there were any thumbnails to be unloaded before scanning. Your...