burmistrzak

Results 158 comments of burmistrzak

> > Hi @Koenkk, this is also a similar issue for the ZNCLDJ12LM, line 2626 in `src/lib/lumi.ts`. Should be 'stopped' and not 'stop'? > > ``` > > if (['ZNCLDJ12LM',...

> When is this expected to be picked up in the main add-on? Would prefer not to swap to dev if I can help it to avoid any future headaches....

> I just tried using the dev branch and it looks like this issue is fixed, however I've run into another problem. I'm now seeing this in my logs when...

> > > I just tried using the dev branch and it looks like this issue is fixed, however I've run into another problem. I'm now seeing this in my...

@clowncracker Hmm, it's possible that your HA configuration still has the old position values saved/discovered? The [specific model](https://github.com/Koenkk/zigbee-herdsman-converters/blob/3553ddedf8cf4ae3751df924b7ea7c0babefacfd/src/devices/lumi.ts#L1889) you've mentioned seems to be already fixed. There's currently only [one model](https://github.com/Koenkk/zigbee-herdsman-converters/blob/3553ddedf8cf4ae3751df924b7ea7c0babefacfd/src/devices/lumi.ts#L1959)...

@itavero What about utilizing `motor_state` for `PositionState` on devices that support it? So we're only updating `CurrentPosition` when `motor_state != idle`, and in cases where the command didn't come from...

@itavero Did you already had time to take a look at the PR? I personally would have preferred to check for `motor_state` like you did with `position` and `tilt`, but...

> Unfortunately I have not had time. Hopefully I can find a moment this week to do at least a quick check, but my schedule is still quite busy. Don't...

@Koenkk FYI, I saw the same error while working on the BTH-RA. That's why I had to revert some changes [between commits](https://github.com/burmistrzak/zigbee-herdsman-converters/compare/burmistrzak:zigbee-herdsman-converters:a548c3ca2b62a9f75448058cb57b6709ff67c3f3...e5596b392e19bc2705049cbced24c2dfebc90de1), otherwise the device would fail to configure, and...

AFAICT, all these devices have in common, that they're using `modernExtend`. Interesting. 👀 **Edit:** In my particular case, it _might_ have been because I forgot to remove a non-existent cluster...