Burak Şen

Results 15 comments of Burak Şen

> Hey @buraksenn, thank you for working on this issue! > > Ignoring `backDiags` when we print `earlyConfDiags` may require users to run init multiple times just to find out...

I want to contribute in long-term but since this is my first commit and I'm not familiar with the project structure and architecture decisions I don't want to proceed without...

> @buraksenn You should be able to continue on this branch with the approach of merging two different lists of diagnostics, removing any exact duplicates. This would probably look something...

@ollevche can you review again if possible?

Is anyone working on this issue? I want to try fixing it cc @cam72cam

> Thank you for volunteering @buraksenn! Please read [the "I've been assigned an issue, now what?" section of the contribution guide](https://github.com/opentofu/opentofu/blob/main/CONTRIBUTING.md#ive-been-assigned-an-issue-now-what) before you begin working. Thanks @cam72cam, I start looking...

Hi @bunniseng are you still working on this issue? If not I would like to work on it

>LGTM, thank you @buraksenn. I wonder how CI passed before the [last commit](https://github.com/apache/datafusion/pull/12972/commits/58d3d86c793a119804a1322d75eb9c3607a64df2) 🤔 Thanks for reviewing the PR. The reason was that in a few lines above: let mut...

> > let mut x = &args[0]; Thus using args[0] did not cause any errors but of course not a best practice afais. > > x is re-set to args[1]...